Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add addresses info to nodes #2137

Merged
merged 7 commits into from
Jul 6, 2023
Merged

Feature/add addresses info to nodes #2137

merged 7 commits into from
Jul 6, 2023

Conversation

axcosta
Copy link
Contributor

@axcosta axcosta commented Jun 8, 2023

Description

This adds the addresses information for the data.kubernetes_nodes.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='run=TestAccKubernetesDataSourceNodes.*'
==> Checking that code complies with gofmt requirements...
go vet .
TF_ACC=1 go test "/home/axcosta/go/src/github.com/hashicorp/terraform-provider-kubernetes/kubernetes" -v -run=TestAccKubernetesDataSourceNodes.* -timeout 3h
=== RUN   TestAccKubernetesDataSourceNodes_basic
--- PASS: TestAccKubernetesDataSourceNodes_basic (11.96s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   11.992s

Release Note

Release note for CHANGELOG:

Added addresses information for the `data.kubernetes_nodes`

References

#2124

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@axcosta axcosta requested a review from a team as a code owner June 8, 2023 00:17
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size/S label Jun 8, 2023
@BBBmau
Copy link
Contributor

BBBmau commented Jun 20, 2023

Hello, thank you for opening this PR @axcosta! Could you also add documentation of this new attribute?

@axcosta
Copy link
Contributor Author

axcosta commented Jun 21, 2023

Hello, thank you for opening this PR @axcosta! Could you also add documentation of this new attribute?

Hello @BBBmau, my first PR here. What kind of documentation is necessary, could you please advise?

@BBBmau
Copy link
Contributor

BBBmau commented Jun 21, 2023

sure thing @axcosta , since addresses is a new attribute in the schema, you'll want to include it as part of the docs

You can edit the docs here

@BBBmau BBBmau self-assigned this Jul 6, 2023
BBBmau
BBBmau approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for contributing!

@BBBmau BBBmau merged commit f4cfa2c into hashicorp:main Jul 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BBBmau BBBmau BBBmau approved these changes

Assignees

@BBBmau BBBmau

Labels
documentation pr/no-changelog size/S waiting-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axcosta @hashicorp-cla @BBBmau